Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify genesis finalized checkpoint root in p2p spec #1867

Merged
merged 2 commits into from
Jun 2, 2020
Merged

clarify genesis finalized checkpoint root in p2p spec #1867

merged 2 commits into from
Jun 2, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 2, 2020

fixes #1848

@djrtwo djrtwo requested a review from protolambda June 2, 2020 17:22
@djrtwo @protolambda
clarify head_root is for a BeaconBlock
cf7b999 
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
protolambda
protolambda approved these changes Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protolambda protolambda merged commit 1f470b3 into dev Jun 2, 2020
@protolambda protolambda deleted the p2p-genesis-root branch June 2, 2020 20:13
@djrtwo djrtwo mentioned this pull request Jun 2, 2020
Merged
@rauljordan rauljordan mentioned this pull request Jun 4, 2020
Merged
@ColinSchwarz ColinSchwarz mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalized Root In Genesis Is Not Clarified
2 participants
@djrtwo @protolambda